Re: [3/10] introduce psymtab users

[Tom Tromey <tromey at redhat dot com>]

>> +  /* A flag that is temporarily used when searching psymtabs.  */
>> +
>> +  unsigned char searched_flag;

Jan> Please make it the enum.

I didn't do this originally because this field and the enum values are
purely temporary.  They have no meaning outside one little bit of the
code.

But, I don't mind, I will make the change.  Very little should be
including psympriv.h anyway.

>> @@ -760,6 +769,11 @@ lookup_partial_symbol (struct partial_symtab
>> *pst, const char *name,
>> static struct symtab *
>> psymtab_to_symtab (struct partial_symtab *pst)
>> {
>> +  /* If it is a shared psymtab, find an unshared psymtab that includes
>> +     it.  Any such psymtab will do.  */
>> +  while (pst->users != NULL)
>> +    pst = pst->users[0];

Jan> Currently GDB already has a problem that if it needs to expand
Jan> symtab A to get symbol X it already expands also symtabs B, C and
Jan> D, all of them pretty big for C++.

Jan> With such random choosing of a symtab for expansion this multi-expand
Jan> performance hit may get even worse for big C++ programs.

Jan> (Not sure if you do not already plan some more general fix for that.)

Someday I would like to implement my lazy CU expansion ideas.
Well, unless we think of something better.  And if we think they'll help
enough; first one of us should redo the performance comparisons.

In the short term, though, I don't think this makes things any worse.
My reasoning is that in the uncompressed DWARF, gdb would read the first
matching CU.  With the compressed DWARF, gdb still does exactly this,
only it reads the CU and the included PUs.

Jan> I do not see why to use the 'keep_going' variable here, just use 'break;'.

Jan> But it applies also to the current code.

Yeah, I don't want to change code I just moved around.
Cleanups are fine separately.

Tom