This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add support for Tilera TILE-Gx processor (part 2/2: gdbserver)
On 04/23/2012 08:59 PM, Jeff Kenton wrote:
>
> jeff kenton (jkenton@tilera.com)
Please see the numerous existing entries in gdb/ChangeLog (for example),
for the proper format of the CL entry's header.
>
> * New target
>
> Tilera TILE-Gx tilegx-*-*
You should turn this part into a proper NEWS patch. Also,
does the patch handle generic tilegx-elf, or just GNU/Linux
(tilegx-*-linux*)? Please adjust the triplet above to reflect reality.
> gdb/gdbserver/
> * configure.srv: added target: tilegx-*-linux*
> * linux-tile-low.c: new file
> * Makefile.in: added files linux-tile-low.c and reg-tilegx.o
Make that present tense, uppercase, and add full stops. Add the change's
context under ()'s. One change (reg-tilegx.c) was missing in the entry.
So you'd end up with:
* configure.srv: Add tilegx-*-linux*.
* linux-tile-low.c: New file.
* Makefile.in (SFILES): Add linux-tile-low.c.
(linux-tile-low.o, reg-tilegx.o, reg-tilegx.c): New rules.
--
Pedro Alves