This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Link gnulib in gdbserver.


On 04/13/2012 04:21 AM, Doug Evans wrote:
> Pedro thinks it's this:
> FLAGS_TO_PASS changes $srcdir.  and install: does @$(MAKE)
> $(FLAGS_TO_PASS) install-only

$(FLAGS_TO_PASS) is used to pass to Makefiles in sub-dirs.  When
invoking install-only target, it is unnecessary to pass
$(FLAGS_TO_PASS).  In the commands of target install-only below,
$(FLAGS_TO_PASS) is passed to Makefiles in sub-dirs.

This patch just simply remove $(FLAGS_TO_PASS) in install target.  Is it OK?

Tested by gdbserver instal/uninstall and gdb install.  It looks right.

-- 
Yao (éå)
gdb:

2012-04-13  Yao Qi  <yao@codesourcery.com>

	* Makefile.in (install): Don't pass $(FLAGS_TO_PASS) to make.

gdb/gdbserver:

2012-04-13  Yao Qi  <yao@codesourcery.com>

	* Makefile.in (install): Don't pass $(FLAGS_TO_PASS) to make.
---
 gdb/Makefile.in           |    2 +-
 gdb/gdbserver/Makefile.in |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index b8b7109..4d80036 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1012,7 +1012,7 @@ gdb.z:gdb.1
 # time it takes for make to check that all is up to date.
 # install-only is intended to address that need.
 install: all
-	@$(MAKE) $(FLAGS_TO_PASS) install-only
+	@$(MAKE) install-only
 
 install-only: $(CONFIG_INSTALL)
 	transformed_name=`t='$(program_transform_name)'; \
diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in
index aa8b13b..84c5834 100644
--- a/gdb/gdbserver/Makefile.in
+++ b/gdb/gdbserver/Makefile.in
@@ -214,7 +214,7 @@ all: gdbserver$(EXEEXT) gdbreplay$(EXEEXT) $(extra_libraries)
 # time it takes for make to check that all is up to date.
 # install-only is intended to address that need.
 install: all
-	@$(MAKE) $(FLAGS_TO_PASS) install-only
+	@$(MAKE) install-only
 
 install-only:
 	n=`echo gdbserver | sed '$(program_transform_name)'`; \
-- 
1.7.0.4


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]