This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] find_partial_die cleanups
- From: Tom Tromey <tromey at redhat dot com>
- To: dje at google dot com (Doug Evans)
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 09 Apr 2012 12:16:15 -0600
- Subject: Re: [patch] find_partial_die cleanups
- References: <20120409174612.1F60824618E@ruffy.mtv.corp.google.com>
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> but I want to check in some preliminary changes so that there's a
Doug> better base to review the patches from, plus make some general
Doug> improvements along the way.
Sounds great.
Doug> This patch is standalone, and so I'm not submitting it as part of a set.
Doug> I will check this in in a few days if there are no objections.
No objections here, just a question and a nit.
Doug> + error (_("Dwarf Error: Type Unit at offset 0x%lx contains"
Doug> + " external reference to offset 0x%lx [in module %s].\n"),
Doug> + (long) cu->header.offset.sect_off, (long) offset.sect_off,
Doug> + bfd_get_filename (objfile->obfd));
Why an error and not a complaint?
I ask because errors have a pretty drastic effect on debuginfo reading.
Doug> + struct dwarf2_section_info* sec;
Wrong "*" placement.
Tom