This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 1/2] Linespec rewrite (update 2)

From: Keith Seitz <keiths at redhat dot com>
To: "gdb-patches at sourceware dot org ml" <gdb-patches at sourceware dot org>
Date: Thu, 05 Apr 2012 12:00:46 -0700
Subject: Re: [RFA 1/2] Linespec rewrite (update 2)
References: <4F70F8F7.503@redhat.com> <87zkb0wj1x.fsf@fleche.redhat.com> <4F74B583.6090008@redhat.com> <87obrertls.fsf@fleche.redhat.com> <4F75D859.1010907@redhat.com> <87r4waqc38.fsf@fleche.redhat.com> <20120330170913.GT2701@adacore.com> <87fwcqq8gl.fsf@fleche.redhat.com> <4F75F5F5.8070105@redhat.com> <4F7B8610.9070302@redhat.com> <87hawygq65.fsf@fleche.redhat.com> <CADPb22SncZ87gY3t4hQx3xpCh2aYfS0oPJPJd_hF0hxCryJPOg@mail.gmail.com>

On 04/05/2012 08:54 AM, Doug Evans wrote:

On Thu, Apr 5, 2012 at 8:21 AM, Tom Tromey<tromey@redhat.com> wrote:
"Keith" == Keith Seitz<keiths@redhat.com> writes:
Keith>  Given Doug's comments earlier today, I'm reposting anything that
Keith>  hasn't already been approved or which changed. The easiest way to see
Keith>  what's happened is, of course, by inspecting the commit history of the
Keith>  branch.
Keith> I'll follow-up separately with the other patch that was updated.

I have no further comments. I think it looks great.

I think at this point you just need Doug's ok.
All I had were nits, so 'tis ok with me.

And with that, I've committed the lot.

Thank you to everyone who reviewed and played with the patchset!

Keith

References:
- Re: [RFA 1/2] Linespec rewrite (update 2)
  - From: Keith Seitz
- Re: [RFA 1/2] Linespec rewrite (update 2)
  - From: Tom Tromey
- Re: [RFA 1/2] Linespec rewrite (update 2)
  - From: Doug Evans

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]