This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH]testsuite: test for disconnected-tracing
- From: Pedro Alves <palves at redhat dot com>
- To: Hui Zhu <hui_zhu at mentor dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org
- Date: Thu, 05 Apr 2012 12:50:45 +0100
- Subject: Re: [PATCH]testsuite: test for disconnected-tracing
- References: <4F71C7F0.90209@mentor.com> <87iphoy2xx.fsf@fleche.redhat.com> <4F73B80C.7050703@mentor.com> <4F744956.4060500@redhat.com> <4F7D5456.9080806@mentor.com>
On 04/05/2012 09:14 AM, Hui Zhu wrote:
> I post a new version patch according to your comments.
> And I have test it with gdb-7.4 and got fail.
Thanks. Only a few nits remain, and this is technically ready to
check in. See below.
However, what's the status of your copyright assignment? Last I
heard (and from what I see in FSF's copyright assignment records), we
still can't accept changes from you on behalf of Mentor. :-(
> 2012-04-05 Hui Zhu <hui_zhu@mentor.com>
>
> * gdb.trace/Makefile.in (PROGS): Add
> disconnected-tracing.
This fits fine on a single line. Please do that.
> * gdb.trace/disconnected-tracing.c: New file.
> * gdb.trace/disconnected-tracing.exp: New file.
>
> --- /dev/null
> +++ b/testsuite/gdb.trace/disconnected-tracing.c
...
> +
> +int
> +main()
Might as well follow the coding standards, and add a space before parens.
> +{
> + return 0;
> +}
> \ No newline at end of file
^^^^^^^^^^^^^^^^^^^^^^^^^
Please add a newline.
--
Pedro Alves