This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: set print object on should affect MI varobjs (PR mi/13393)
- From: Doug Evans <dje at google dot com>
- To: xgsa <xgsa at yandex dot ru>
- Cc: Eli Zaretskii <eliz at gnu dot org>, Tom Tromey <tromey at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 2 Apr 2012 17:53:59 -0700
- Subject: Re: set print object on should affect MI varobjs (PR mi/13393)
- References: <4ED92C05.9080803@yandex.ru> <m3mxanjiy0.fsf@fleche.redhat.com> <4EF22A4D.80703@yandex.ru> <20111221193630.GA28985@host2.jankratochvil.net> <4EF30389.5010008@yandex.ru> <20111223200951.GA19581@host2.jankratochvil.net> <4EF5D1C5.5010902@yandex.ru> <20120102022153.GA686@host2.jankratochvil.net> <4F07177C.5080201@yandex.ru> <m38vkfljq5.fsf@fleche.redhat.com> <4F32C009.2050103@yandex.ru> <87pqdma1mo.fsf@fleche.redhat.com> <4F412637.2010405@yandex.ru> <4F660CF6.9070008@yandex.ru> <8339953anu.fsf@gnu.org> <4F66DBD0.4000903@yandex.ru> <83vcm01obe.fsf@gnu.org> <4F6CADEF.4080700@yandex.ru> <83vclmynmz.fsf@gnu.org> <4F761708.8080105@yandex.ru> <83r4w9zua0.fsf@gnu.org> <45311333142751@web61.yandex.ru> <83obrdz579.fsf@gnu.org> <87971333177060@web108.yandex.ru> <4F76CF8B.9060303@yandex.ru>
On Sat, Mar 31, 2012 at 2:34 AM, xgsa <xgsa@yandex.ru> wrote:
> Hi,
>
> Here is the previous patch with the Tom's and Eli's review comments fixed.
Hi. ChangeLog nit:
To improve the S/N ratio of the ChangeLog entry, instead of:
(adjust_value_for_child_access): Extended with a new parameter which
specify whether the given value should be casted to enclosing type.
(c_number_of_children): Updated for extended
adjust_value_for_child_access.
(c_describe_child): Updated for extended
adjust_value_for_child_access.
(cplus_number_of_children): Updated for extended
adjust_value_for_child_access.
(cplus_describe_child): Updated for extended
adjust_value_for_child_access.
write this:
(adjust_value_for_child_access): Extended with a new parameter which
specify whether the given value should be casted to enclosing type.
All callers updated.
and that's it.
I.e., don't write entries for each caller, just say "All callers updated."
[I know, a bit of a hassle this time, but next time you'll have less
to type. :-)]