This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Finalizing fix committed for "[PATCH] sim: make sure to include strsignal prototype"


On Sunday 25 March 2012 03:40:20 Mike Frysinger wrote:
> the BFD64 logic in gas' expr.c is fairly light.  i'm not even sure it makes
> sense to key off of BFD64 since this code doesn't use bfd for number
> processing.  it's just deciding whether to automatically upgrade bignum's
> into int64's.  i'll post a patch to just delete the BFD64 logic there and
> see what people have to say.

ok, digging a bit more, that isn't going to work.  the gas parsing logic is 
tied too closely to the bfd_vma type which is directly tied to the 
aforementioned configure flag.

since the fact.s test already tests both values (full & truncated), and in 
reality the compiled code is the same for both (since gas does the 
truncation), i've commented out the test that is larger than 32bits.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]