Re: Please fix regressions from your sim changes

[Mike Frysinger <vapier at gentoo dot org>]

On Monday 19 March 2012 19:50:42 Hans-Peter Nilsson wrote:
> From: Mike Frysinger <vapier@gentoo.org>
> > On Monday 19 March 2012 02:28:49 Hans-Peter Nilsson wrote:
> > > For mips-elf, there's just
> > 
> > mips-elf is passing for me
> > 
> > > FAIL: mips1 hilo-hazard-1.s (execution)
> > 
> > the glob should eat the new signal string
> > 
> > > And really, why removing the "program stopped with signal"
> > > common part?  I see no reason to not just adding it back.
> > 
> > it wasn't removed.  the signal is now additionally being decoded.
> > 
> > before: program stopped with signal 5.
> > after: program stopped with signal 5 (Trace/breakpoint trap).
> 
> That's what you'd think (and that'd be an improvement), but the
> message really is all gone.  Is it a host issue?  The tester
> host is admittedly an aging installation, F 8 x86_64.

if you run it manually, do you get the full string ?  it's passing on my side 
just fine:

spawn /usr/local/src/gnu/sourceware/build/build-mips/sim/testsuite/../mips/run 
hilo-hazard-1.s.x
HILO: MULT: OP at 0x80010048 too close to MF at 0x80010044

program stopped with signal 6 (Aborted).
PASS: mips1 hilo-hazard-1.s

you can see the commit in question clearly doesn't remove the msg:
--- a/sim/common/nrun.c
+++ b/sim/common/nrun.c
-	fprintf (stderr, "program stopped with signal %d.\n", sigrc);
+	fprintf (stderr, "program stopped with signal %d (%s).\n", sigrc,
+		strsignal (sigrc));

maybe strsignal() is crashing ?  what version of glibc ?
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.