This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/5] move tp installation to cmd_qtdp
On 03/07/2012 03:31 PM, Yao Qi wrote:
> function `install_tracepoint' does something irrelevant to installing
> tracepoint. This patch is to move irrelevant code out of it.
"irrelevant" is arguable, but, okay.
>
> 2012-03-07 Yao Qi <yao@codesourcery.com>
>
> * tracepoint.c (install_tracepoint): Move tracepoint installation
> irrelevant code to ...
"irrelevant" would be a "why", not a "what".
So perhaps, "Move duplicate tracepoint handling to ..." .
> (cmd_qtdp): ... here.
> +
> download_tracepoint (tpoint);
> - install_tracepoint (tpoint, own_buf);
> +
> + if (tpoint->type == trap_tracepoint || tp == NULL)
> + install_tracepoint (tpoint, own_buf);
> + else
> + write_ok (own_buf);
This will need a bit of adjustment for the case where installing the
tracepoint fails already in the tree.
Otherwise okay.
--
Pedro Alves