This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add dll trampoline code handling for windows 64bit
- From: Tom Tromey <tromey at redhat dot com>
- To: Roland Schwingel <roland at onevision dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 14 Mar 2012 09:34:04 -0600
- Subject: Re: [PATCH] Add dll trampoline code handling for windows 64bit
- References: <4F609EB7.2020801@onevision.com>
>>>>> "Roland" == Roland Schwingel <roland@onevision.com> writes:
Roland> - The jump destination is on 64bit windows of course 8 byte
Roland> long. I could not find a function that transforms this into a
Roland> CORE_ADDR like read_memory_unsigned_integer() it is doing in the
Roland> 32bit case. So I did the transformation on my own. While this
Roland> is high performant it might not be the "official" gdb way. If
Roland> someone can give me a hint on how to the transformation the
Roland> "official" way I will adjust my patch - if wished.
Just use read_memory_unsigned_integer.
I think it is guaranteed that CORE_ADDR will not be larger than
ULONGEST.
I can't really comment on the rest of your patch.
I think it is big enough that it requires a copyright assignment.
If you don't have one, contact me off-list to get started.
Tom