This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] AIX: Add another way of setting up the frame pointer to skip_prologue


Re:

2012-03-08  Chris January  <chris.january@allinea.com>

        * rs6000-tdep.c (skip_prologue): Support the oril r29, r1, 0x0
        instruction.

> > > > Same comments as before: Looks good, but has it been validated against
> > > > the testsuite?
> > > 
> > > No, I have not got the test suite working reliably on AIX yet.
> > 
> > If you have a Linux PowerPC box available, you could run the testsuite
> > there to check for regressions.
> 
> I did just that, and there were no regressions.

Thanks, Chris. I checked the patch in for you.

Have we started the process for giving you write priviledges so
that you can commit the patches yourself?

PS: Does your mailer wrap long lines? If that's the case, can you send
    patches in attachment instead? I couldn't get this patch to apply
    even after fixing an obvious long-line automatic-wrap-around. So
    I applied it by hand, and verified that the file still compiled.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]