This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Support Fortran common blocks with addresses >INT_MAX.
- From: Chris January <chris dot january at allinea dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 12 Mar 2012 08:45:10 +0000
- Subject: Re: [PATCH] Support Fortran common blocks with addresses >INT_MAX.
- References: <1331217037.2742.10.camel@gumtree> <20120309193904.GF2853@adacore.com>
On Fri, 2012-03-09 at 11:39 -0800, Joel Brobecker wrote:
> > The address of a Fortran common block may be >INT_MAX. fix_common_block
> > should be using CORE_ADDR, not int.
> >
> > 2012-03-08 Chris January <chris.january@allinea.com>
> >
> > * stabsread.c (fix_common_block): Change type of valu argument
> > to CORE_ADDR.
>
> This change looks correct to me too. Did you run the testsuite to
> validate the change, by any chance?
No, although there aren't any test cases in testsuite/gdb.fortran that
use a common block anyway.
> Do you have copyright assignment papers on file with the FSF? If not,
> this change is sufficiently small that we can accept it, as well as
> your other contribution ("Add another way of setting up [...]").
Yes, we have a company-wide assignment.
Chris