Re: [PATCH] AIX: Add another way of setting up the frame pointer to skip_prologue

[Joel Brobecker <brobecker at adacore dot com>]

Chris,

> Add support for compilers that use the oril r29, r1, 0x0 instruction to
> set up the frame pointer.
> 
> 2012-03-08  Chris January  <chris.january@allinea.com>
> 
>         * rs6000-tdep.c (skip_prologue): Support the oril r29, r1, 0x0
> 	instruction.

Same comments as before: Looks good, but has it been validated against
the testsuite?

I am just going to suggest one tiny change, which is a bit of a nitpick,
but I think makes the code relatively consistent:

> ---
> diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
> index a8ff777..9d4fd40 100644
> --- a/gdb/rs6000-tdep.c
> +++ b/gdb/rs6000-tdep.c
> @@ -1822,6 +1822,15 @@ skip_prologue (struct gdbarch *gdbarch, CORE_ADDR
> pc, CORE_ADDR lim_pc,
>  
>           /* Set up frame pointer */
>         }
> +      else if (op == 0x603d0000        /* oril r29, r1, 0x0 */)

I would put the comment outside of the closing parens. I know we do
this for multi-line conditions, but this one fits in a single line,
so we can put it outside, and that way, it doesn't look like a parens
is missing.

> +       {
> +         fdata->frameless = 0;
> +         framep = 1;
> +         fdata->alloca_reg = (tdep->ppc_gp0_regnum + 29);
> +         continue;
> +
> +         /* Another way to set up the frame pointer.  */
> +       }
>        else if (op == 0x603f0000        /* oril r31, r1, 0x0 */
>                || op == 0x7c3f0b78)
>         {                       /* mr r31, r1 */
> 

-- 
Joel