This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Darwin build fix for unused prototypes

From: Tristan Gingold <gingold at adacore dot com>
To: Josh Matthews <josh at joshmatthews dot net>
Cc: gdb-patches at sourceware dot org
Date: Fri, 9 Mar 2012 09:41:33 +0100
Subject: Re: [patch] Darwin build fix for unused prototypes
References: <CAOvJiVVT4_Gqw==81sT0bQ5MLfWiZ6ROMqjZRKrsqp2XtZU9_Q@mail.gmail.com>

On Mar 8, 2012, at 7:36 PM, Josh Matthews wrote:

> 2012-03-08  Josh Matthews  <josh@joshmatthews.net>
> 
>        * darwin-nat-info.c: Add missing prototype for
> _initialize_darwin_info_commands. Make darwin_debug_port_info static.
>        * darwin-nat.c: Add missing prototype for _initialize_darwin_infereior.
>        * i386-darwin-nat.c: Remove unused functions
> i386_darwin_dr_set, i386_darwin_dr_get, i386_darwin_set_control,
> i386_darwin_get_control, i386_darwin_dr_set_addr,
> i386_darwin_get_addr, i386_darwin_get_status, i386_darwin_get_control.
>        * machoread.c: Add missing prototype for _initialize_machoread.
> <darwin_prototypes.diff>

Hi Josh,

the 'add missing prototype' parts are OK.  Please commit (if you have commit rights) or tell me if I have to do so.

I'd prefer to keep the i386-darwin-nat.c functions that deal with hardware watchpoint, although I still have to enable this.
Maybe a temporary '#ifdef HW_WATCHPOINT_NOT_YET_ENABLED' would be better in this case.

Tristan.

References:
- [patch] Darwin build fix for unused prototypes
  - From: Josh Matthews

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]