Re: [RFA] Make breakpoint condition detection trace conditional on remote_debug.

[Luis Gustavo <luis_gustavo at mentor dot com>]

On 03/08/2012 03:42 PM, Joel Brobecker wrote:
> Hello,
>
> I am investigating a problem where a breakpoint with a condition
> no longer stops the program when running the program through gdbserver.
> One of the things I noticed is this message that keeps popping up in
> the gdbserver output:
>
>      % gdbserver :4444 a
>      Process a created; pid = 10100
>      Listening on port 4444
>      Remote debugging from host 127.0.0.1
>      Found breakpoint condition.
>      Found breakpoint condition.
>      Found breakpoint condition.
>
> This looks like a debugging trace that should only be enable if
> requested.
>
> What do you guys think of this patch.  I'm a little under pressure,
> so I didn't test the patch, but I will if it looks correct. I wasn't
> sure whether I should have used debug_threads or remote_debug...
>
> gdb/gdbserver/ChangeLog:
>
>          * server.c (process_point_options): If a conditional expression
>          is found, only print a message if remote_debug is nonzero.
>
> Thanks,


Thanks for the fix, it is the right thing.

Do you have the testcase handy? I can do some digging...

Did the condition go to the target? How did it evaluate?

Luis