This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 1/2] libunwind/ia64: Rename libunwind-frame.[ch]


On Tue, 06 Mar 2012 08:54:35 +0100, Pedro Alves wrote:
> On 03/04/2012 09:57 PM, Jan Kratochvil wrote:
> > this is just a rename, it breaks the build, but it makes the changes
> > reviewable in [patch 2/2].  It would be checked-in as a single commit.
> 
> BTW, there's a different way to split this so that you don't mix
> the rename with other changes to the same files, and so that
> git log sees through pure file renames without trouble.

'git log' never see a rename while 'git log -M' sees the rename even if those
changes are in single commit as those changes are really very small:

diff --git a/gdb/libunwind-frame.h b/gdb/ia64-libunwind-tdep.h
similarity index 93%
rename from gdb/libunwind-frame.h
rename to gdb/ia64-libunwind-tdep.h
index a6b3c34..221bbd2 100644
--- a/gdb/libunwind-frame.h
+++ b/gdb/ia64-libunwind-tdep.h
@@ -1,4 +1,4 @@
-/* Frame unwinder for frames with libunwind frame information.
+/* Frame unwinder for ia64 frames with libunwind frame information.
[...]

So I do not find a need to use multiple commits into the (CVS) repository.


I was posting it this way so that one can easily apply the series by 'patch'
while still being able to see the changes (in [patch 2/2]).

If one can assume every mailing list user has GIT anyway the repository
absolutely no longer makes sense in CVS.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]