Re: Regressions in gdbserver mode #2 [Re: General regressions in gdbserver mode]

[Luis Gustavo <luis_gustavo at mentor dot com>]

On 02/26/2012 06:54 PM, Jan Kratochvil wrote:
> On Sat, 25 Feb 2012 20:58:53 +0100, Luis Gustavo wrote:
> > I've checked the following in.
>
> Still getting now these regressions in gdbserver non-extended mode:
>
> -PASS: gdb.base/save-bp.exp: info break
> +FAIL: gdb.base/save-bp.exp: info break
> +FAIL: gdb.cp/mb-templates.exp: initial condition: run to breakpoint (timeout)
> +FAIL: gdb.cp/mb-templates.exp: initial condition: run to breakpoint 2 (GDB internal error)
> +FAIL: gdb.cp/mb-templates.exp: ...
>
> info break
> Num     Type           Disp Enb Address            What
> 2       breakpoint     keep y   0x0000000000400540 in break_me at ./gdb.base/save-bp.c:21
> 3       breakpoint     keep y   0x000000000040054a in main at ./gdb.base/save-bp.c:27
> 4       breakpoint     keep y   0x000000000040054f in main at ./gdb.base/save-bp.c:28 thread 1
>          stop only in thread 1
> 5       breakpoint     keep y   0x000000000040055d in main at ./gdb.base/save-bp.c:31
>          stop only if i == 1 (host evals)
> 6       breakpoint     keep y   0x000000000040056c in main at ./gdb.base/save-bp.c:33
>          silent
> (gdb) FAIL: gdb.base/save-bp.exp: info break
>
> (I did not check now what is expeted.)
>
> (gdb) continue
> Continuing.
> ax-gdb.c:560: internal-error: gen_fetch: bad type code
> A problem internal to GDB has been detected,
> further debugging may prove unreliable.
> Quit this debugging session? (y or n) Found breakpoint condition.
> FAIL: gdb.cp/mb-templates.exp: initial condition: run to breakpoint (timeout)
>
>
> Regards,
> Jan

What about the following to fix save-bp.exp? Hopefully the syntax is 
correct.

Luis
2012-02-27  Luis Machado  <lgustavo@codesourcery.com>

	* gdb.base/save-bp.exp: Account for new condition evaluator output.

diff --git a/gdb/testsuite/gdb.base/save-bp.exp b/gdb/testsuite/gdb.base/save-bp.exp
index 439a20e..7d63dc3 100644
--- a/gdb/testsuite/gdb.base/save-bp.exp
+++ b/gdb/testsuite/gdb.base/save-bp.exp
@@ -66,4 +66,4 @@ gdb_test "source bps"
 # Now, verify that all breakpoints have been created correctly...
 set bp_row_start "\[0-9\]+ +breakpoint +keep +y +0x\[0-9a-f\]+ +in"
 gdb_test "info break" \
-  " *Num +Type +Disp +Enb +Address +What\r\n$bp_row_start break_me at .*$srcfile:\[0-9\]+\r\n$bp_row_start main at .*$srcfile:$loc_bp2\r\n$bp_row_start main at .*$srcfile:$loc_bp3 +thread 1\r\n\[ \t]+stop only in thread 1\r\n$bp_row_start main at .*$srcfile:$loc_bp4\r\n\[ \t\]+stop only if i == 1\r\n$bp_row_start main at .*$srcfile:$loc_bp5\r\n\[ \t\]+silent"
+  " *Num +Type +Disp +Enb +Address +What\r\n$bp_row_start break_me at .*$srcfile:\[0-9\]+\r\n$bp_row_start main at .*$srcfile:$loc_bp2\r\n$bp_row_start main at .*$srcfile:$loc_bp3 +thread 1\r\n\[ \t]+stop only in thread 1\r\n$bp_row_start main at .*$srcfile:$loc_bp4\r\n\[ \t\]+stop only if i == 1( \\((host|target) evals\\))?\r\n$bp_row_start main at .*$srcfile:$loc_bp5\r\n\[ \t\]+silent"