Re: [RFA take 5] Allow setting breakpoints on inline functions (PR 10738)

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Mon, 20 Feb 2012 15:58:49 +0000
> From: Gary Benson <gbenson@redhat.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, Mark Wielaard <mark@klomp.org>,
>         Jan Kratochvil <jan.kratochvil@redhat.com>,
>         Doug Evans <dje@google.com>
> 
> This patch makes GDB able to set breakpoints on inlined functions.

Thanks.

> I have updated the documentation part of the patch to retain all
> information about older versions, and also to document the new
> option.
> 
> How does it look?

Looks good, but I have a couple of minor comments.

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -44,6 +44,8 @@
>  * The command "info catch" has been removed.  It has been disabled
>    since December 2007.
>  
> +* GDB can now set breakpoints on inlined functions.
> +

I think we should also advertise the new command-line option in NEWS.

> +@item -allow-incomplete-gdb-indexes
> +@cindex @code{--allow-incomplete-gdb-indexes}
> +This option causes @value{GDBN} to read and use possibly incomplete
> +@samp{.gdb_index} sections in symbol files.  This can speed up
> +startup, but may result in some functionality being lost.

Please add here a cross-reference to the node "Index Section Format",
because the effect of this option is not fully understood until the
reader reads there.

The documentation parts are OK, with those comments taken care of.