This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] sim: Update sim_{fetch,store}_register for sh and mn10300


On Wed, 15 Feb 2012 23:54:20 -0500
Mike Frysinger <vapier@gentoo.org> wrote:

> On Wednesday 15 February 2012 19:13:19 Kevin Buettner wrote:
> > The patch below updates sim_fetch_register for both mn10300 and sh
> > to return the length of the value being fetched instead of -1.  For
> > sh, sim_store_register() is changed in a like fashion.
> > 
> > This change is necessary due to past changes to remote-sim.c which do
> > more stringent checks of the return value.
> > 
> > Comments?
> 
> i assume `make sim-check` passes for the sh target, so OK

I ran that test; it does pass.

> > sim/ChangeLog:
> > 
> > 	* sh/interp.c (sim_store_register, sim_fetch_register): Return
> > 	length, not -1.
> 
> note: there is a sim/sh/ChangeLog

Thanks.  I've put that entry in sim/sh/ChangeLog.

I've committed this patch.  Thanks for the quick approval!

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]