This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] rl78: Rearrange order in which registers are displayed
- From: Pedro Alves <palves at redhat dot com>
- To: Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 14 Feb 2012 18:53:23 +0000
- Subject: Re: [RFC] rl78: Rearrange order in which registers are displayed
- References: <20120209171537.20c1c6b1@mesquite.lan>
On 02/10/2012 12:15 AM, Kevin Buettner wrote:
> The patch below uses register groups to shorten the list of registers
> displayed when "info registers" is used. It adds some pseudo registers
> and rearranges others so that the banked registers are displayed at
> the end for "info all-registers". The register order from 0 to NREGS
> stays the same.
>
> This change was requested by Renesas. They wanted the more useful and
> important registers displayed earlier on for "info all-registers".
>
> I considered writing a custom method for printing registers, but it
> seems that this approach has fallen out of favor these days. Also, I
> would guess that the custom approach might not be compatible with MI
> enabled clients.
>
> Comments?
FWIW, looks fine to me.
> +/* Implement the `register_sim_regno' gdbarch method. */
> +
> +static int
> +rl78_register_sim_regno(struct gdbarch *gdbarch, int regnum)
Missing space before parens.
--
Pedro Alves