Re: [RFA take 4] Allow setting breakpoints on inline functions (PR 10738)

[Gary Benson <gbenson at redhat dot com>]

Hi Doug,

Doug Evans wrote:
> On Mon, Feb 13, 2012 at 10:47 AM, Gary Benson <gbenson@redhat.com> wrote:
> > Hi all,
> >
> > This patch makes GDB able to set breakpoints on inlined functions.
> >
> > This version of the patch has been updated to fix the issues Jan
> > pointed out with the last version.
> >
> > This patch bumps the version number of the .gdb-index to 6, but
> > it does not remove any of the backwards compatibility code which
> > I would prefer to do as a separate patch.
> 
> I agree support for older versions should be a separate patch.
> However this patch doesn't do that (it removes current acceptance
> of older versions of the index).

That's correct.  The older versions do not contain partial symbols
for inlined functions.  If GDB were to be run on a file with an
older versioned index without rejecting it then the ability to set
breakpoints on inlined functions would silently fail.

The separate patch I was referring to would involve the removal of
some extra code that is present to support version 4 indexes.  For
example there is a local copy of the hashing function which could
be removed or could be retained depending on people's wishes.  I
thought it would be simpler to discuss that separately from this.

Cheers,
Gary

-- 
http://gbenson.net/