This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Add a parameter `own_buf' to handle_monitor_command
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 Feb 2012 12:51:37 +0000
- Subject: Re: [patch] Add a parameter `own_buf' to handle_monitor_command
- References: <4F328A9E.9000202@codesourcery.com>
On 02/08/2012 02:45 PM, Yao Qi wrote:
> Hi,
> At the end of gdbserver/server.c:handle_monitor_command, global variable
> `own_buf' is used. However, in the caller of handler_monitor_command,
> handle_query, `own_buf' is passed as the first parameter. This gives me
> a feeling that we should pass `own_buf' to handle_monitor_command as
> parameter as well.
>
> This patch is quite trivial, and original code works. I still feel we
> should get rid of using global variables as much as we can.
Ok.
--
Pedro Alves