This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Fix PR gdb/12953: No hardware watchpoints on FreeBSD amd64
- From: Pedro Alves <palves at redhat dot com>
- To: Valery Khromov <valery dot khromov at gmail dot com>
- Cc: gdb-patches at sourceware dot org, Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Date: Thu, 09 Feb 2012 16:10:21 +0000
- Subject: Re: [PATCH v2] Fix PR gdb/12953: No hardware watchpoints on FreeBSD amd64
- References: <201112201931.pBKJV4bh021140@glazunov.sibelius.xs4all.nl> <1324411833-38717-1-git-send-email-valery.khromov@gmail.com>
On 12/20/2011 08:10 PM, Valery Khromov wrote:
> This patch provides hardware breakpoint/watchpoint support for
> FreeBSD/AMD64. Most of the code is borrowed from the i386 implementation.
Thanks. It looks good to me. I've applied the patch now.
> Also removed not necessary DBREG_DRX macro definition.
> 2011-12-20 Valery Khromov <valery.khromov@gmail.com>
>
> * i386bsd-nat.c: [HAVE_PT_GETDBREGS] (DBREG_DRX): Delete.
But without this bit though. Mark only mentioned that the macro always
exists on amd64, not i386:
> That bit can go. FreeBSD/amd64 has always had the DBREG_DRX macro, at
> least ever since support for debug registers was added.
The code does mention that some versions may need it:
/* Not all versions of FreeBSD/i386 that support the debug registers
have this macro. */
#ifndef DBREG_DRX
#define DBREG_DRX(d, x) ((&d->dr0)[x])
#endif
So if this can also be removed, let's do that separately.
--
Pedro Alves