On 1/27/12 12:32 PM, Luis Gustavo wrote:
Hi,
This is an updated series of patches to implement target-side
breakpoint condition evaluation.
Overall this is looking pretty good, I just have a few nitpicks of my
own - fix those and it all should be fine to go in.
The current testsuite seems to be a good exercise for this feature
when ran in gdbserver mode. I can provide additional tests if required.
I would like to see at least one test of the preference setting that
runs in native mode and comes back with "not supported". I think this is
something that people will imagine is possible for native debugging, and
maybe someday it will be, but in the meantime we want to be sure that
the native config clearly reports that the setting is not going to have
any effect.