This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
FYI: fix PR 9307
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 02 Feb 2012 07:57:36 -0700
- Subject: FYI: fix PR 9307
I'm checking this in.
This fixes PR 9307. The bug is that a "display" of an instance field
won't work inside a method.
I tracked this down to a missing set of block_found.
Incidentally, I would like to get rid of block_found by turning it into
a parameter. I consider it very ugly as is.
Built and regtested on x86-64 Fedora 15. New test case included.
Tom
2012-02-02 Tom Tromey <tromey@redhat.com>
PR gdb/9307:
* symtab.c (lookup_language_this): Set block_found.
2012-02-02 Tom Tromey <tromey@redhat.com>
* gdb.cp/dispcxx.exp: New file.
* gdb.cp/dispcxx.cc: New file.
diff --git a/gdb/symtab.c b/gdb/symtab.c
index c6314c9..61f7536 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -1232,7 +1232,10 @@ lookup_language_this (const struct language_defn *lang,
sym = lookup_block_symbol (block, lang->la_name_of_this, VAR_DOMAIN);
if (sym != NULL)
- return sym;
+ {
+ block_found = block;
+ return sym;
+ }
if (BLOCK_FUNCTION (block))
break;
block = BLOCK_SUPERBLOCK (block);
diff --git a/gdb/testsuite/gdb.cp/dispcxx.cc b/gdb/testsuite/gdb.cp/dispcxx.cc
new file mode 100644
index 0000000..2bc15e4
--- /dev/null
+++ b/gdb/testsuite/gdb.cp/dispcxx.cc
@@ -0,0 +1,39 @@
+/* Test for displays in C++.
+
+ Copyright 2012 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
+*/
+
+struct K {
+ void method () { }
+
+ int k;
+
+ K() : k(23) { }
+
+ int m2 ()
+ {
+ k += 7; // Break here
+ return k;
+ }
+};
+
+int main() {
+ K k;
+
+ k.method();
+ return k.m2();
+}
+
diff --git a/gdb/testsuite/gdb.cp/dispcxx.exp b/gdb/testsuite/gdb.cp/dispcxx.exp
new file mode 100644
index 0000000..da35c11
--- /dev/null
+++ b/gdb/testsuite/gdb.cp/dispcxx.exp
@@ -0,0 +1,41 @@
+# Copyright 2012 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+if { [skip_cplus_tests] } { continue }
+
+set testfile dispcxx
+set srcfile ${testfile}.cc
+set binfile ${objdir}/${subdir}/${testfile}
+
+if [get_compiler_info ${binfile} "c++"] {
+ untested dispcxx.exp
+ return -1
+}
+
+if {[prepare_for_testing $testfile.exp $testfile $srcfile {debug c++}]} {
+ return -1
+}
+
+if ![runto_main] then {
+ perror "couldn't run to main"
+ continue
+}
+
+gdb_breakpoint [gdb_get_line_number "Break here"]
+gdb_continue_to_breakpoint here
+
+# Regression test for
+# http://sourceware.org/bugzilla/show_bug.cgi?id=9307.
+gdb_test "display k" "1: k = 23"