This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[03/10] watchpoint.exp: do a clean restart after tests that don't require `initialize' anymore


Most of the tests that appeared over time don't need the `initialize'
business.  Issue a clean restart to make that clear, and so that hidden
dependencies don't appear in the future.

2012-01-26  Pedro Alves  <palves@redhat.com>

	* gdb.base/watchpoint.exp: Clean restart after tests that don't
	require `initialize' anymore.  Remove unnecessary `initialize'
	calls.
---

 gdb/testsuite/gdb.base/watchpoint.exp |   15 ++++-----------
 1 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/gdb/testsuite/gdb.base/watchpoint.exp b/gdb/testsuite/gdb.base/watchpoint.exp
index 16fe05f..9aeb5ec 100644
--- a/gdb/testsuite/gdb.base/watchpoint.exp
+++ b/gdb/testsuite/gdb.base/watchpoint.exp
@@ -781,17 +781,12 @@ if [initialize] then {

     if ![target_info exists gdb,cannot_call_functions] {
 	test_stepping
-
-	# See above.
-	if [istarget "mips-idt-*"] then {
-	    gdb_exit
-	    gdb_start
-	    gdb_reinitialize_dir $srcdir/$subdir
-	    gdb_load $binfile
-	    initialize
-	}
     }

+    # Tests below don't rely on the markers and watchpoint set by
+    # `initialize' anymore.
+    clean_restart $testfile
+
     # Only enabled for some targets merely because it has not been tested
     # elsewhere.
     # On sparc-sun-sunos4.1.3, GDB was running all the way to the marker4
@@ -806,7 +801,6 @@ if [initialize] then {
 	gdb_start
 	gdb_reinitialize_dir $srcdir/$subdir
 	gdb_load $binfile
-	initialize
     }

     # Only enabled for some targets merely because it has not been tested
@@ -852,7 +846,6 @@ if [initialize] then {
 	gdb_start
 	gdb_reinitialize_dir $srcdir/$subdir
 	gdb_load $binfile
-	initialize
     }

     test_watchpoint_and_breakpoint


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]