This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc v3][0/6] Remote /proc file access
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org, palves at redhat dot com
- Date: Wed, 18 Jan 2012 15:38:07 +0400
- Subject: Re: [rfc v3][0/6] Remote /proc file access
- References: <OF5DB6AADD.80E0AB5F-ONC1257988.006C1C48@de.ibm.com>
> Joel, would you mind re-running the tests on a procfs target
> since this patch does change the procfs.c file, which I cannot
> test ... Thanks!
I ran the testsuite on mips-irix, and got one real semi-regression:
info proc^M
Not supported on this target.^M
(gdb) FAIL: gdb.base/info-proc.exp: info proc without a process
I think it's just a matter of the output having changed. I couldn't
verify it completely, because I had lost the gdb.log file from the
reference run (they are now split, and I only saved the top one).
If it wasn't intended, I'd still consider this an improvement since
the expected output was:
No current process: <something like please select one>
I never feel completely confident about runs on mips-irix, because
GDB does not work at all with programs that use threading. AdaCore
has some local changes regarding this feature, but they are very
hacky and would probably not pass a normal review.
I cannot test using the standard testsuite on sparc-solaris. But
I can run our testsuite. So I applied your changes to our own tree,
and ran the testsuite. Found no regression. I think that's an extra
vote of confidence.
--
Joel