This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc v3][4/6] Readlink as file I/O target operation
- From: Pedro Alves <palves at redhat dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 17 Jan 2012 20:08:46 +0000
- Subject: Re: [rfc v3][4/6] Readlink as file I/O target operation
- References: <201201171947.q0HJlcHD024179@d03av02.boulder.ibm.com>
Only minor nits:
On 01/17/2012 07:47 PM, Ulrich Weigand wrote:
> + /* Read value of symbolic link FILENAME on the remote target. Return
> + a null-terminated string allocated via xmalloc, or NULL if an error
> + occurs (and set *REMOTE_ERRNO). */
> + char *(*to_fileio_readlink) (const char *filename, int *remote_errno);
> +
s/the remote target/the target/
s/REMOTE_ERRNO/TARGET_ERRNO/.
s/remote_errno/target_errno/.
I spotted several instances of this in this patch.
--
Pedro Alves