This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 8/8] Pascal language
- From: Tom Tromey <tromey at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 16 Jan 2012 11:11:54 -0700
- Subject: Re: [RFC 8/8] Pascal language
- References: <m3k44s7qej.fsf@gmail.com> <m3d3ak6auu.fsf@gmail.com>
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> This is the patch for the Pascal language. I forgot to mention in the
Sergio> other patches: I also took the liberty (in all files) to cleanup #if 0
Sergio> functions, and to convert old-style function declarations to use the
Sergio> "new" style, i.e.:
It is generally better to do different cleanups separately.
I know it can be a pain to do this, but at least now we have "git stash" :)
Removing most #if 0 code is obvious. There may be an individual case or
two where there is some controversy. Anyway, please do it, use your
best judgment and trust that people will push back if you pick the wrong
one :).
Converting K&R -> ANSI style is obvious as well. Please just put these
in.
Tom