This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb.ada/catch_ex.exp, gdb.ada/mi_catch_ex.exp and unsupported catchpoints
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Pedro Alves <pedro at codesourcery dot com>, Joel Brobecker <brobecker at adacore dot com>, gdb-patches at sourceware dot org
- Date: Tue, 10 Jan 2012 20:25:51 +0000
- Subject: Re: [PATCH] gdb.ada/catch_ex.exp, gdb.ada/mi_catch_ex.exp and unsupported catchpoints
- References: <201112061718.50031.pedro@codesourcery.com> <201112091800.02236.pedro@codesourcery.com> <m3d3bxfwci.fsf@fleche.redhat.com> <201112101926.40691.pedro@codesourcery.com> <m3fwgfmh2u.fsf@fleche.redhat.com>
On 12/20/2011 02:51 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
>
> Pedro> Here's a start. I didn't really try to confirm if I was extracting the
> Pedro> arguments correctly for any other function bug the Ada runtime's
> Pedro> function in question, but at least it works in the case we're
> Pedro> interested in. :-)
>
> I think it looks pretty good.
>
> If you put this in, I will look at making the next-over-throw code use
> it.
That sounds nice. Joel wasn't very keen on it, so I'm not sure about the Ada
parts. I've now put it at:
https://github.com/palves/gdb/tree/build_prototype
> Pedro> + /* The FULL_NAME pointer is at offset 8 of the object pointed by
> Pedro> + E. */
> Pedro> + full_name_val = value_at (void_ptr_type, e + 8);
>
> 8 seems wrong on 32 bit.
It looked okay to me, as the two preceding members are 4 bytes
each, on both 32-bit and 64-bit, but ICBW.
> Now, of course, we need struct layout code... :-)
In any case, that'd be nice. :-)
--
Pedro Alves