This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix PR gdb/12953: No hardware watchpoints on FreeBSD amd64
- From: Pedro Alves <alves dot ped at gmail dot com>
- To: gdb-patches at sourceware dot org
- Cc: Valery Khromov <valery dot khromov at gmail dot com>
- Date: Tue, 20 Dec 2011 16:02:53 +0000
- Subject: Re: [PATCH] Fix PR gdb/12953: No hardware watchpoints on FreeBSD amd64
- References: <1323132864-14029-1-git-send-email-valery.khromov@gmail.com>
On Tuesday 06 December 2011 00:54:24, Valery Khromov wrote:
> + /* FIXME: kettenis/2001-03-31: Calling perror_with_name if the
> + ptrace call fails breaks debugging remote targets. The correct
> + way to fix this is to add the hardware breakpoint and watchpoint
> + stuff to the target vector. For now, just return zero if the
> + ptrace call fails. */
This is no longer necessary, and was recently removed everywhere. See:
<http://sourceware.org/ml/gdb-patches/2011-12/msg00139.html>
> + if (ptrace (PT_GETDBREGS, PIDGET (inferior_ptid),
> + (PTRACE_TYPE_ARG3) &dbregs, 0) == -1)
> +#if 0
> + perror_with_name (_("Couldn't read debug registers"));
> +#else
> + return 0;
> +#endif
--
Pedro Alves