This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[commit+7.4] [patch+7.4] reread.exp 7.3->7.4 regression

From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
To: Ulrich Weigand <uweigand at de dot ibm dot com>
Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org, Joel Brobecker <brobecker at adacore dot com>, Pedro Alves <alves dot ped at gmail dot com>
Date: Mon, 19 Dec 2011 23:39:13 +0100
Subject: [commit+7.4] [patch+7.4] reread.exp 7.3->7.4 regression
References: <20111219191201.GA7401@host2.jankratochvil.net> <201112192137.pBJLb4UZ026021@d06av02.portsmouth.uk.ibm.com>

On Mon, 19 Dec 2011 22:37:04 +0100, Ulrich Weigand wrote:
> > No regressions on {x86_64,x86_64-m32,i686}-fedora16-linux-gnu and on
> > arm-fedora13beta-linux-gnu.  OK to check it in and for 7.4?
> > 
> > gdb/
> > 2011-12-19  Jan Kratochvil  <jan.kratochvil@redhat.com>
> > 
> > 	* symfile.c (reread_symbols): Move free_objfile_separate_debug,
> > 	preserve_values, sym_finish and clear_objfile_data calls before BFD
> > 	close.  Move free_objfile_separate_debug as the very first call.  New
> > 	comment on the ordering.
> 
> This looks reasonable to me, and seems preferable to the ARM-specific hack ...

Checked in and for 7.4:
	http://sourceware.org/ml/gdb-cvs/2011-12/msg00197.html
	http://sourceware.org/ml/gdb-cvs/2011-12/msg00198.html


Thanks for the review,
Jan

References:
- Re: [patch+7.4] reread.exp 7.3->7.4 regression
  - From: Jan Kratochvil
- Re: [patch+7.4] reread.exp 7.3->7.4 regression
  - From: Ulrich Weigand

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]