This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[committed] [patch] Replace magic numbers with macros in gdbserver/tracepoint.c


On 12/12/2011 05:43 PM, Jan Kratochvil wrote:
> On Mon, 12 Dec 2011 03:30:35 +0100, Yao Qi wrote:
>> -    ipa_trace_buffer_ctrl_curr = (0x80000000
>> +    ipa_trace_buffer_ctrl_curr = ( GDBSERVER_UPDATED_FLUSH_COUNT_BIT
>                                      ^ excessive space
> therefore:
> # +    ipa_trace_buffer_ctrl_curr = (GDBSERVER_UPDATED_FLUSH_COUNT_BIT
> 

Right, get it fixed.

> 
>>  				  | (prev << 12)
>>  				  | counter
>>  				  | curr_tbctrl_idx);
> 
> I have verified the constants.
> 

Thanks for the review.  Committed.
http://sourceware.org/ml/gdb-cvs/2011-12/msg00106.html

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]