Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode

[Tristan Gingold <gingold at adacore dot com>]

On Dec 9, 2011, at 5:30 PM, Pedro Alves wrote:

[…]
> 
> On Monday 05 December 2011 16:01:02, Pedro Alves wrote:
>> I have tested this on x86_64-linux (-m64|-m32), which showed no
>> regressions.  The patch also adjusts all other users of i396-nat.c:
>> djgpp/go32; i386 BSDs (FreeBSD only it seems); Windows (cygwin/mingw)
>> and macosx (darwin), but I haven't tested those.  I'd appreciate
>> testing or an extra pair of eyes.
>> 
>> Actually darwin has the i386 watchpoint hooks in place, but it doesn't
>> install them:
>> 
>> $ grep i386_darwin_dr_get_status *
>> i386-darwin-nat.c:i386_darwin_dr_get_status (void)
>> $
>> 
>> ??
> 
> Anyone want to comment on those platform bits?
> 
> Tristan, are we just missing a patchlet to glue 
> i386-darwin-nat.c with i386-nat.c.?

Correct.  HW watchpoint are currently not enabled on Darwin, but almost all the code is here.  I will try to fix that soon.

Thanks,
Tristan.