Re: Formal regression of gdb.trace/tfind.exp [Re: [PATCH v2] Tracing notes and metadata]

[Stan Shebs <stanshebs at earthlink dot net>]

On 12/5/11 1:48 AM, Jan Kratochvil wrote:
> On Thu, 17 Nov 2011 21:34:35 +0100, Stan Shebs wrote:
> > 2011-11-17  Stan Shebs<stan@codesourcery.com>
> >
> >      * NEWS: Mention tracepoint additions.
> [...]
>
> commit 9a8d1c3ed58f9f92c7f3dfb43499e427c63513be
>
> FAIL: gdb.trace/tfind.exp: 6.2: help tstart
> FAIL: gdb.trace/tfind.exp: 7.2: help tstop
>
> This is a formal regression.

I blame Tom. :-)  Fixed thusly and committed:

2011-12-05  Stan Shebs <stan@codesourcery.com>

    * gdb.trace/tfind.exp: Update help string matches.

Index: gdb.trace/tfind.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.trace/tfind.exp,v
retrieving revision 1.23
diff -u -p -r1.23 tfind.exp
--- gdb.trace/tfind.exp    1 Jan 2011 15:33:50 -0000    1.23
+++ gdb.trace/tfind.exp    5 Dec 2011 23:30:52 -0000
@@ -109,7 +109,7 @@ if { $return_me == 1 } then {
 gdb_test "tstatus" "\[Tt\]race is running.*" "test tstatus on"

 # 6.2 test help tstart
-gdb_test "help tstart" "Start trace data collection." "6.2: help tstart"
+gdb_test "help tstart" "Start trace data collection\.\[\r\n\]+Usage: 
tstart \\\[ <notes> \.\.\. \\\]\[\r\n\]+Any arguments supplied are 
recorded with the trace as a note and\[\r\n\]+reported by tstatus \\(if 
the target supports trace notes\\)\." "6.2: help tstart"

 gdb_test "break end" ".*" ""
 gdb_test "continue" \
@@ -140,7 +140,7 @@ if { $return_me == 1 } then {
 }

 # 7.2 test help tstop
-gdb_test "help tstop" "Stop trace data collection." "7.2: help tstop"
+gdb_test "help tstop" "Stop trace data collection\.\[\r\n\]+Usage: 
tstop \\\[ <notes> \.\.\. \\\]\[\r\n\]+Any arguments supplied are 
recorded with the trace as a stop reason and\[\r\n\]+reported by tstatus 
\\(if the target supports trace notes\\)\." "7.2: help tstop"

 # test tstatus (when trace off)
 gdb_test "tstatus" "Trace stopped by a tstop command.*" \