This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 034/238] [misc.] Fix -Wshadow warnings.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Andrey Smirnov <andrew dot smirnov at gmail dot com>
- Cc: gdb-patches at sourceware dot org, Pedro Alves <pedro at codesourcery dot com>
- Date: Mon, 5 Dec 2011 14:26:46 +0100
- Subject: Re: [PATCH 034/238] [misc.] Fix -Wshadow warnings.
- References: <4ECC3FD2.1000309@earthlink.net> <1322493561-29643-1-git-send-email-andrew.smirnov@gmail.com> <20111205113032.GK2777@adacore.com> <CAHQ1cqH+fTNU3mtvw-woHuv4nn5ti3UR-pqKFbRGsq_DDiPukQ@mail.gmail.com>
> > Looks OK to me. But Pedro might comment on the new variable name
> > (sal->sal2).
[...]
> Initially it was sal->las which probably isn't better, so I'll wait
> for some consensus to arise on this patch too.
FWIW, I'm OK with sal2. I also agree with stan that it's best to
avoid `las' (cute, though :-))
--
Joel