This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Regression for gdb.base/jit.exp and gdb.base/jit-so.exp [Re: JIT Interface Patches Landed]


> Could you review these comments there?

I've checked in the attached patch.
-- 
Sanjoy Das
http://playingwithpointers.com
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c759514..a8d71f4 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2011-11-29  Sanjoy Das  <sdas@igalia.com>
+
+	* jit.c (add_objfile_entry, jit_reader_try_read_symtab)
+	(jit_bfd_try_read_symtab): Fix comments.
+
 2011-11-28  DJ Delorie  <dj@redhat.com>
 
 	* NEWS: Mention RL78 simulator.
diff --git a/gdb/jit.c b/gdb/jit.c
index 099f79d..843c768 100644
--- a/gdb/jit.c
+++ b/gdb/jit.c
@@ -239,7 +239,8 @@ struct jit_inferior_data
   CORE_ADDR descriptor_addr;  /* &__jit_debug_descriptor  */
 };
 
-/* Remember a mapping from entry_addr to objfile.  */
+/* Remember OBJFILE has been created for struct jit_code_entry located
+   at inferior address ENTRY.  */
 
 static void
 add_objfile_entry (struct objfile *objfile, CORE_ADDR entry)
@@ -711,8 +712,8 @@ jit_object_close_impl (struct gdb_symbol_callbacks *cb,
 }
 
 /* Try to read CODE_ENTRY using the loaded jit reader (if any).
-   ENTRY_ADDR is the address of the object file (in the target's
-   address space) being read.  */
+   ENTRY_ADDR is the address of the struct jit_code_entry in the
+   inferior address space.  */
 
 static int
 jit_reader_try_read_symtab (struct jit_code_entry *code_entry,
@@ -769,7 +770,7 @@ jit_reader_try_read_symtab (struct jit_code_entry *code_entry,
 }
 
 /* Try to read CODE_ENTRY using BFD.  ENTRY_ADDR is the address of the
-   object file (in the target's address space) being read.  */
+   struct jit_code_entry in the inferior address space.  */
 
 static void
 jit_bfd_try_read_symtab (struct jit_code_entry *code_entry,

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]