This is the mail archive of the
mailing list for the GDB project.
Re: Regression for gdb.base/jit.exp and gdb.base/jit-so.exp [Re: JIT Interface Patches Landed]
On Sun, 27 Nov 2011 15:42:32 +0100, Sanjoy Das wrote:
> -/* Try to read CODE_ENTRY using the loaded jit reader (if any). */
> +/* Try to read CODE_ENTRY using the loaded jit reader (if any).
> + ENTRY_ADDR is the address of the object file (in the target's
> + address space) being read. */
> static int
> -jit_reader_try_read_symtab (struct jit_code_entry *code_entry)
> +jit_reader_try_read_symtab (struct jit_code_entry *code_entry,
> + CORE_ADDR entry_addr)
The problem is ENTRY_ADDR is not the object file address.
SYMFILE_ADDR is the object file address. ENTRY_ADDR is the address of the
inferior struct jit_code_entry. The bug was these two can be different.
Also the comment
/* Remember a mapping from entry_addr to objfile. */
add_objfile_entry (struct objfile *objfile, CORE_ADDR entry)
is not saying much, there should be something like:
/* Remember OBJFILE has been created for struct jit_code_entry located
at inferior address ENTRY. */
Could you review these comments there?