This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 20/348] Fix -Wsahdow warnings


On Wed, Nov 23, 2011 at 11:39 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>> From: Andrey Smirnov <andrew.smirnov@gmail.com>
>> Date: Tue, 22 Nov 2011 20:02:56 +0700
>>
>> From: Andrey Smirnov <andrew.smirnov@gmail.com>
>> Date: Tue, 22 Nov 2011 17:29:45 +0700
>>
>> * amd64-tdep.c (amd64_push_dummy_call): Fix -Wshadow
>> warnings.
>
> That's a stupid change. ?Please simply remove the 2nd tdep declaration
> in that function and leave the rest of the code as is.
>

That may very well be, but changing it that way allowed me, a person without
solid knowledge of the codebase, to be sure I didn't introduce any
side effects since changing it the way you propose would rewrite the
value of `tdep'. That was my reasoning for doing it. Was it
invalid?

Andrey Smirnov

P.S. I'll change it.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]