This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 22/348] Fix -Wsahdow warnings

From: Doug Evans <dje at google dot com>
To: Mike Frysinger <vapier at gentoo dot org>
Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches at sourceware dot org, Andrey Smirnov <andrew dot smirnov at gmail dot com>, Marek Polacek <mpolacek at redhat dot com>
Date: Wed, 23 Nov 2011 09:25:12 -0800
Subject: Re: [PATCH 22/348] Fix -Wsahdow warnings
References: <878vn88fw3.fsf@gmail.com> <201111221027.52484.vapier@gentoo.org> <20111122160539.GA22283@adacore.com> <201111221120.06244.vapier@gentoo.org>

On Tue, Nov 22, 2011 at 8:20 AM, Mike Frysinger <vapier@gentoo.org> wrote:
>> > your ChangeLogs are also incorrect. ?it should not be:
>> > ? ? * bcache.c (expand_hash_table): Fix -Wshadow warnings.
>> >
>> > but rather:
>> > ? ? * bcache.c (expand_hash_table): Rename bcache to cache.
>>
>> I'm 50/50 on this. I don't mind either way. What do others think?
>> Is that really that important that we must create boring extra work
>> for Andrey?
>
> it's my understanding that the GNU changelog style is "document what changed"
> and not "why". ?i think that's largely stupid, but i'm not the one in control
> of said policy.

For little things like this, at least for those that are internal to a function,
I've seen a lot of leeway and I think that's ok.
fwiw.

References:
- [PATCH 22/348] Fix -Wsahdow warnings
  - From: Andrey Smirnov
- Re: [PATCH 22/348] Fix -Wsahdow warnings
  - From: Mike Frysinger
- Re: [PATCH 22/348] Fix -Wsahdow warnings
  - From: Joel Brobecker
- Re: [PATCH 22/348] Fix -Wsahdow warnings
  - From: Mike Frysinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]