This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 22/348] Fix -Wsahdow warnings

On Tuesday 22 November 2011 09:04:07 Andrey Smirnov wrote:
> On Tue, Nov 22, 2011 at 8:35 PM, Marek Polacek <> wrote:
> > On 11/22/2011 02:33 PM, Andrey Smirnov wrote:
> >>> Is the typo intentional?
> >> 
> >> Sorry about that. No it isn't. Please ignore that particular patch I'll
> >> send corrected version soon(I'm in the middle of a git rebase
> >> --interactive, so I can't edit that particular commit just yet).
> > 
> > That typo is in other patches too.
> OK, once again, sorry about that, I'll recheck all the patches related
> to bcache.c, for now please ignore those.

please condense down your patches if you resend.  there's way too many little 
tiny ones that really should be squashed into a single changeset.

your ChangeLogs are also incorrect.  it should not be:
	* bcache.c (expand_hash_table): Fix -Wshadow warnings.
but rather:
	* bcache.c (expand_hash_table): Rename bcache to cache.

Attachment: signature.asc
Description: This is a digitally signed message part.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]