Re: [doc RFA] "New" command "!"

[Doug Evans <dje at google dot com>]

On Fri, Nov 11, 2011 at 11:29 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Fri, 11 Nov 2011 09:18:55 -0800
>> From: Doug Evans <dje@google.com>
>>
>> --- NEWS ? ? ?2 Nov 2011 23:44:19 -0000 ? ? ? 1.464
>> +++ NEWS ? ? ?11 Nov 2011 15:46:51 -0000
>> @@ -104,6 +104,12 @@
>> ? ?at the time the function got called. ?Entry values are available only since
>> ? ?gcc version 4.7.
>>
>> +* New commands
>> +
>> +!SHELL COMMAND
>> + ?"!" is now an alias of the "shell" command.
>> + ?Note that no space is needed between "!" and SHELL COMMAND.
>
> This is okay.
>
>> ?@item shell @var{command string}
>> +@itemx ! @var{command string}
>
> There should be no space between `!' and the rest, right?
>
> Also, I'd suggest to tell here explicitly what you told in NEWS:
>
> ?Note that no space is needed between @code{!} and @var{command string}.
>
> Btw, it is customary not to have spaces in @var. ?Use hyphens or
> underscores instead. ?(Yes, I know it was that way before you added
> the alias.)
>
> Thanks.
>

Here is what I committed.

2011-11-14  Doug Evans  <dje@google.com>

        Make "!" an alias for "shell".
        * NEWS: Add mention.
        * cli/cli-cmds.c (init_cli_cmds): Remove xdb_commands
condition on adding "!" command, always add it.
        * cli/cli-decode.c (find_command_name_length): Recognize "!"
as a command of length one.

        doc/
        * gdb.texinfo (Shell Commands): Document "!".

        testsuite/
        * gdb.base/shell.exp: New file.

Attachment: gdb-111114-bang-3.patch.txt
Description: Text document