This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] testsuite: Add (extensive) hardware breakpoint testing
On Sat, 12 Nov 2011, Pedro Alves wrote:
> > Well, OOC I looked at the relevant source and the bug (and consequently
> > the fix) is quite obvious -- the debug registers are only actually pushed
> > down to hardware on data breakpoints and not execution breakpoints.
> Ugh, my fault...
Well, that happens sometimes and it just shows we do really need this
test case. :)
NB I have deliberately omitted the skip_hw_breakpoint_tests check here as
I think we should test the failure modes too. If a target does not
support hardware breakpoints, then it should handle any requests to use
one gracefully, which this test case will record as unsupported. If any
targets still score failures here, then they need to be investigated.
> > 2011-11-11 Maciej W. Rozycki <email@example.com>
> > gdb/
> > * i386-nat.c (i386_insert_hw_breakpoint): Call
> > i386_update_inferior_debug_regs.
> > (i386_remove_hw_breakpoint): Likewise.
> Okay. Thanks!
Committed now, thanks for the review.