This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH - TUI and Insight Related] Fix for PR13378
- From: Sterling Augustine <saugustine at google dot com>
- To: gdb-patches at sourceware dot org
- Date: Fri, 11 Nov 2011 12:53:59 -0800
- Subject: [PATCH - TUI and Insight Related] Fix for PR13378
Hi,
Enclosed is a very simple patch which fixes the annoying TUI-updating
issue described in
http://sourceware.org/bugzilla/show_bug.cgi?id=13378.
It simply eliminates a call to
deprecated_selected_frame_level_changed_hook. This hook has been
deprecated for many years, so one would think it's clients have had
time to remove the dependency. After using it locally for a week now,
I see no ill effects in TUI. stopping at breakpoints, up, down, and
the other stuff all work fine for me. However, the testsuite is, err,
incomplete on this feature.
I do wonder if Insight--or some other front end--might have a problem
with it though. If you deal with TUI or another front end, can you
take it for a spin?
If this patch is accepted, then the next logical one would be to
eliminate the hook altogether, but that will require changes to
Insight.
Thanks,
Sterling
2011-11-11 Sterling Augustine <saugustine@google.com>
PR gdb/13378
* frame.c (select_frame): Don't call
deprecated_selected_frame_level_changed_hook. Eliminate obsolete
FIXME.
Index: frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.303
diff -u -r1.303 frame.c
--- frame.c 27 Oct 2011 11:04:25 -0000 1.303
+++ frame.c 11 Nov 2011 20:50:56 -0000
@@ -1396,17 +1396,6 @@
selected_frame = fi;
/* NOTE: cagney/2002-05-04: FI can be NULL. This occurs when the
frame is being invalidated. */
- if (deprecated_selected_frame_level_changed_hook)
- deprecated_selected_frame_level_changed_hook (frame_relative_level (fi));
-
- /* FIXME: kseitz/2002-08-28: It would be nice to call
- selected_frame_level_changed_event() right here, but due to limitations
- in the current interfaces, we would end up flooding UIs with events
- because select_frame() is used extensively internally.
-
- Once we have frame-parameterized frame (and frame-related) commands,
- the event notification can be moved here, since this function will only
- be called when the user's selected frame is being changed. */
/* Ensure that symbols for this frame are read in. Also, determine the
source language of this frame, and switch to it if desired. */