This is the mail archive of the
mailing list for the GDB project.
Re: RFC: remove gdbarch from struct breakpoint
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Joel Brobecker <brobecker at adacore dot com>, Tom Tromey <tromey at redhat dot com>, Ulrich Weigand <uweigand at de dot ibm dot com>
- Date: Mon, 7 Nov 2011 16:09:39 +0000
- Subject: Re: RFC: remove gdbarch from struct breakpoint
- References: <firstname.lastname@example.org> <20111107152058.GD14508@adacore.com>
On Monday 07 November 2011 15:20:58, Joel Brobecker wrote:
> > This patch removes the 'gdbarch' field from struct breakpoint.
> > In most cases, it is sufficient to replace the use of this field with
> > the location's gdbarch instead. In fact, I think the cases in
> > tracepoint.c where this is not done are probably latent bugs.
> I think that makes sense. I am trying to figure out how a breakpoint
> could have a gdbarch that made some sort of sense when the breakpoint
> has two locations and each location had a different gdbarch from
> the other....
History behind the fields:
Reading the first url, I was wondering if we'd indeed need the
breakpoint's gdbarch for reparsing conditions and watchpoint
expressions (or anything that uses expressions instead of linespecs),
but I can't find such dependency in the code. Maybe Ulrich can
take a look at this. The Cell combined debugger can maybe
reveal hidden dependencies with the gdbarch fallbacks we do.
> In most cases, it is sufficient to replace the use of this field with
> the location's gdbarch instead. In fact, I think the cases in
> tracepoint.c where this is not done are probably latent bugs.