This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: JIT Reader


>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:

Sanjoy> +void *gdb_dlopen(const char *filename)
Sanjoy> +{
Sanjoy> +  gdb_assert_not_reached ("gdb_dlopen should not be called on this platform.");
Sanjoy> +  return NULL;
Sanjoy> +}

Wrong formatting -- the GNU style puts the function name at the start of
the line.  This is true for all the new functions.

gdb_assert_not_reached does not return, so you don't need a 'return'
here.  Also true in all the new functions.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]