This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename)
- From: Tom Tromey <tromey at redhat dot com>
- To: iam ahal <hal9000ed2k at gmail dot com>
- Cc: gdb-patches at sourceware dot org, eliz at gnu dot org, pmuldoon at redhat dot com, brobecker at adacore dot com, pedro at codesourcery dot com, drow at false dot org, jan dot kratochvil at redhat dot com
- Date: Wed, 02 Nov 2011 13:05:41 -0600
- Subject: Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename)
- References: <BANLkTinD+9_Mkug8o2VhZ03L6XSriL_RKQ@mail.gmail.com> <m3oc1kfheh.fsf@redhat.com> <20110627160029.GF20676@adacore.com> <m3sjqt67pe.fsf@fleche.redhat.com> <m3mxh1oa8a.fsf@redhat.com> <CAA18ubJ10sh3pPDLp4V44qY6r6hLU9RqyDi62KuAAtfXJY7Oug@mail.gmail.com> <834o33qlm9.fsf@gnu.org> <CAA18ubJZK7w51Bmwvy7xYXPvHf7e=bbRbdBOqNvZA-PrXJpUsA@mail.gmail.com> <E1Qdhn8-0000fE-TK@fencepost.gnu.org> <CAA18ubJAvwHt-sq8XN98PhC=LSFXPbcy4P1+AVic-G=MNE7R2A@mail.gmail.com> <CAA18ubLBZseSxqjWSk1jH7OeZi06K_o75HKc0CN-_iCAjQ5boA@mail.gmail.com> <83bowq6x7f.fsf@gnu.org> <CAA18ub+ox5kmHu=1qvMkwNfzbCxMdy3M4Z8eKuheaiqyjxJvEg@mail.gmail.com> <m3d3gu77uk.fsf@fleche.redhat.com> <CAA18ubL6ofB9X+2nJC3jUCTEqZBbWL4=wXHgBkOFKJaAOXsiow@mail.gmail.com> <m3vcue1jal.fsf@fleche.redhat.com> <CAA18ubL9TG7we7bi3U_0DQw8KLXNaYCfGa91KQrvC2jM=6DsBw@mail.gmail.com>
>>>>> "Eldar" == iam ahal <hal9000ed2k@gmail.com> writes:
Eldar> Copyright assignment by [gnu.org #703515] is completed.
Eldar> I've corrected some pieces of the patch by your notes.
Eldar> Also, I've attached the change log.
Thanks.
Eldar> diff -rup gdb-7.3.1-orig/gdb/doc/gdb.texinfo gdb-7.3.1/gdb/doc/gdb.texinfo
I don't recall whether this has had a doc review yet.
I think the patch should also include a NEWS entry.
Eldar> +@item set backtrace filename-display basename
Eldar> +Display only basename of a filename.
Eldar> +
Eldar> +@item set backtrace filename-display basename
Eldar> +Display a filename without the compile directory part.
"basename" is repeated; I think the second one should be
without-compile-directory.
Eldar> + const char *filename_display = get_filename_display_from_sal (&sal);
Eldar> + if (filename_display == NULL)
Blank line between these two lines.
Eldar> 2011-10-30 Eldar Gaynetdinov <hal9000ed2k@gmail.com>
Eldar> Add a new variable that controls a way in which filenames in
Eldar> backtraces is displayed.
Eldar> * gdb.texinfo: Added description of 'filename-display' variable in
Eldar> 'set/show backtrace' section.
doc/ has its own ChangeLog, so this entry must go there.
Otherwise looks good, I think one more revision + doc review and it is
ready.
Tom