This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit, spu] Fix "set spu stop-on-load" regression (Re: [1/6] breakpoints_ops for all kinds of breakpoints: there's always a breakpoint->ops)
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: pedro at codesourcery dot com (Pedro Alves)
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 26 Oct 2011 19:31:00 +0200 (CEST)
- Subject: [commit, spu] Fix "set spu stop-on-load" regression (Re: [1/6] breakpoints_ops for all kinds of breakpoints: there's always a breakpoint->ops)
Pedro Alves wrote:
> (create_breakpoint): Assert ops is never NULL. Adjust to pass the
> ops to set_raw_breakpoint_without_location rather than setting it
> manually.
I guess this caused a regression for the "set spu stop-on-load" command;
spu_catch_start calls create_breakpoint with a NULL ops parameter.
Fixed by the following patch. Tested on powerpc64-linux (Cell/B.E.),
committed to mainline.
Bye,
Ulrich
ChangeLog:
* spu-tdep.c (spu_catch_start): Pass non-NULL breakpoint ops
to create_breakpoint.
Index: gdb/spu-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/spu-tdep.c,v
retrieving revision 1.74
diff -u -p -r1.74 spu-tdep.c
--- gdb/spu-tdep.c 5 Aug 2011 01:46:13 -0000 1.74
+++ gdb/spu-tdep.c 24 Oct 2011 11:02:47 -0000
@@ -1939,8 +1939,8 @@ spu_catch_start (struct objfile *objfile
bp_breakpoint /* type_wanted */,
0 /* ignore_count */,
AUTO_BOOLEAN_FALSE /* pending_break_support */,
- NULL /* ops */, 0 /* from_tty */, 1 /* enabled */,
- 0 /* internal */);
+ &bkpt_breakpoint_ops /* ops */, 0 /* from_tty */,
+ 1 /* enabled */, 0 /* internal */);
}
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com