This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/commit/ia64-linux] Allow libunwind to fetch register 0

Hi again Pedro,

I will make the small changes you suggested at the beginning of
the patch. I just wanted to confirm something:

> > +      gdb_assert (sizeof (r0_value) == register_size (gdbarch, regnum));
> > +      regcache_raw_supply (regcache, regnum, r0_value);
> > +      return;
> > +    }
> > +
> I don't speak ia64, but this is the right direction.
> I think we should make ia64_cannot_fetch_register return true for
> gr0 too though.

I assume that you mean that ia64_cannot_fetch_register should return
False as well (meaning that we can in fact fetch the register - don't
you love double negatives?). I had originally interpreted the name
of that function very strictly, meaning that, no, the kernel does
not provide that register value, so we cannot fetch it.  But at the
same time, I think I see you point of having the fetch_register
routine saying we can get the value, while at the same time the
cannot_fetch_register function says we can't.

I will send a new patch...


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]